winmm: Avoid casting return value of Heap(Re)Alloc calls.

[Michael Stefaniuc]

On 10/23/2011 02:41 PM, Dan Kegel wrote:
> 2011/10/22 Frédéric Delanoy <frederic.delanoy at gmail.com>:
>> OK thx. Should probably restructure that section as well (and add
>> -Werror to my CFLAGS)
> 
> How would people feel if configure turned on -Werror
> when it's safe to if building from git?  Something like this:
This isn't safe at all. The quality of the gcc's and libraries used
vary. And newer gcc tend to add additional warnings, e.g. there are
still warnings with gcc-4.6.

What helps is to pass "-s" to make to suppress the normal make output.
That way it is waaay easier to see warnings/errors.
$ git am /tmp/winmm\:\ Avoid\ casting\ return\ value\ of\
Heap\(Re\)Alloc\ calls..eml
$ make -j4 -s
dlls/winmm/lolvldrv.c: In function ‘MMDRV_InitPerType’:
dlls/winmm/lolvldrv.c:406:13: warning: pointer of type ‘void *’ used in
arithmetic [-Wpointer-arith]
dlls/winmm/lolvldrv.c:411:13: warning: pointer of type ‘void *’ used in
arithmetic [-Wpointer-arith]
Wine build complete.

The normal make output is too noisy to be useful.

bye
	michael

> 
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1715,6 +1715,16 @@ then
>    if test "x$enable_maintainer_mode" = "xyes"
>    then
>        WINE_TRY_CFLAGS([-Werror])
> +  else
> +    dnl Enable -Werror when building from git on 32 bit x86 with gcc
> +    case $host_cpu in
> +      *i[[3456789]]86*)
> +        if test "x${GCC}" = "xyes" && test -d $srcdir/.git
> +        then
> +          WINE_TRY_CFLAGS([-Werror])
> +        fi
> +      ;;
> +    esac
>    fi
> 
>    dnl Check for ms_hook_prologue support