cmd: Avoid mixing signed and unsigned type in conditional expression
Frédéric Delanoy
frederic.delanoy at gmail.com
Thu Oct 27 07:09:12 CDT 2011
On Thu, Oct 27, 2011 at 08:38, Eric Pouech <eric.pouech at orange.fr> wrote:
> why do we check for ptr being null or not, when we deref ptr one line above?
>> if (*ptr == '\n') ptr++;
>> - WCMD_output_asis_len(message, (ptr) ? ptr - message :
>> strlenW(message), handle);
>> + WCMD_output_asis_len(message, (ptr) ? (DWORD)(ptr - message) :
>> strlenW(message), handle);
>> if (ptr) {
>> numChars = 0;
>> if (++line_count >= max_height - 1) {
It's dereferenced but incremented afterwards, so might be null after that line
More information about the wine-devel
mailing list