[1/5] ddraw: Simplify Z format parsing a bit, remove ERRs

Henri Verbeet hverbeet at gmail.com
Thu Sep 1 06:27:28 CDT 2011


On 1 September 2011 11:01, Stefan Dösinger <stefan at codeweavers.com> wrote:
>                  case 32:
>                      if(DDPixelFormat->u2.dwStencilBitDepth == 8)
>                          return WINED3DFMT_D24_UNORM_S8_UINT;
> -                    else
> +                    else if (DDPixelFormat->u2.dwStencilBitDepth == 4)
>                          return WINED3DFMT_S4X4_UINT_D24_UNORM;
I'm not sure if this is intentional or not, but you fallthrough to the
default case here. If that's intentional, a /* Fallthrough */ or
similar comment wouldn't hurt. On the other hand, you do explicitly
handle it in the no-stencil case.



More information about the wine-devel mailing list