[PATCH 2/9] cmd: use GetCommandline() rather than argv

Dan Kegel dank at kegel.com
Tue Sep 20 09:28:08 CDT 2011


Hi Martin,
on my i7 machine, your patch series fails every time for me when run
normally.  Here's the log:

]] ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p
cmd.exe_test.exe.so batch.c && touch batch.ok
]] ...
]] wine: cannot find L"C:\\windows\\system32\\tell;1;;2.exe"
]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 50 (got '0 ', wanted '0 at space@')
]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line
53 (got 'error 9009', wanted '1 at space@')
]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line
59 (got 'error 9009', wanted '1 at space@')
]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line
62 (got 'error 9009', wanted '2 at space@')
]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 75 (got '"hi"', wanted '"hi"')
]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line
78 (got 'error 9009', wanted '1 at space@')
]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 81 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted
'"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"')
]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 90 (got '1 ', wanted '1 at space@')
]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 93 (got '0 ', wanted '0 at space@')
]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0
position -1 in line 102 (got '3 ', wanted '3 at space@')
]] Command exited with non-zero status 10
]] make: *** [batch.ok] Error 10
]] make: Target `test' not remade because of errors.

When run with WINEDEBUG=warn+heap, it passes.  Not sure what to make of
that, but something's fishy, and the patch should not go in as is.
You might try valgrind to see if it turns anything up.
- Dan



More information about the wine-devel mailing list