winmm: waveOutReset returns all buffers.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Tue Sep 27 06:35:43 CDT 2011


Dan,

>Fails to apply here.  (Requires fuzz, which Alexandre says is verboten.)
>error: dlls/winmm/waveform.c: patch does not apply

This raises the question about when to use [PATCH X/Y] and/or whether
buildbots should apply all precedingly submitted patches that did not fail.

I tend to use X/Y subject lines when patches depend on each other in the
sense that one should not apply patch #2 without #1.

There was no such dependency here, one could commit or reject each individually.

The only particularity about yesterday's patches is that there were 2 patches
to the same function, waveOutReset. Trying to apply the second one without
the first obviously needs a "fuzz", yet the second patch *can* be used stand alone.

Luckily, AJ is much smarter than the bot, and all patches went in.

Regards,
 Jörg Höhle


More information about the wine-devel mailing list