gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)

[Alexandre Julliard]

Daniel Lehman <dlehman at esri.com> writes:

> Was mistakenly sent to wine-devel
>
> try 2 - integrate into existing tests; updated commit message
>
> I think the only points in the middle of the points array can cause
> the crash I was seeing.  wide_pen_lines trims coincident points/empty
> segments from the beginning and end of the array, so the
> wine_line_segment calls before and after the for loop I modified will
> always return valid faces

It doesn't work here:

../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c && touch dib.ok
dib.c:1324: Test failed: 8888: wide pen - empty segments: expected hash 5bac9c515315bced1ac5cb46a771690d02040278 got 56cc0584aaeb790419b343dae0ea09591c384ac4
dib.c:1324: Test failed: 8888 - bitfields: wide pen - empty segments: expected hash 5bac9c515315bced1ac5cb46a771690d02040278 got 56cc0584aaeb790419b343dae0ea09591c384ac4
dib.c:1324: Test failed: a8b8g8r8: wide pen - empty segments: expected hash 1aa5e414c797fd74fe1400757548ef79650fe994 got ee5a5dc02ec61af2462c265424943049ea7c23eb
dib.c:1324: Test failed: r10g10b10: wide pen - empty segments: expected hash 65f7fc7219e7cc29d20aeab7d38a60ac6c303726 got d7ee8801ea0c3e7cf012153b77bd7ba9b388f459
dib.c:1324: Test failed: r6g6b6: wide pen - empty segments: expected hash b1e3aeac484f49b1874033509924627ef0a4c3bc got 906c2d8da24180ccbe84fd4fd5ba964d8f9a3a44
dib.c:1324: Test failed: 24: wide pen - empty segments: expected hash f11f301314f9729ab351294a4d8a72b72fc2491d got 9433b11e4190cf1d77f4b84017e8561884ccd73c
dib.c:1324: Test failed: r5g5b5: wide pen - empty segments: expected hash ffa75c684138fdb296f4001e2dc36ed1ae33065b got e141eb6b73e91eb2e4b5fd31688084d4b4c70d30
dib.c:1324: Test failed: r4g4b4: wide pen - empty segments: expected hash 9aa687dc13503e3ff4e12e67c361ca140cbdb48d got 27afb67bda17491c7806f1a42650deb9d47bba71
dib.c:1324: Test failed: 8 color: wide pen - empty segments: expected hash 7897ba51f37e01c6a54a2733459e79285b52d213 got d905bc3cd08fc4a7110608ec8b80e494077e859e
dib.c:1324: Test failed: 8 grayscale: wide pen - empty segments: expected hash 88eb0c6542a2c03036241cdb5e08f13401a92f31 got bef8347c9bc96d709aaf002fcf6b4da66e5267e7
dib.c:1324: Test failed: 8: wide pen - empty segments: expected hash 00b34f58bb4876b597fad1a275bccb2c9a95967b got 3f318b982da1b8d26eff59ed8c6d7ce6a84f857a
dib.c:1324: Test failed: 4: wide pen - empty segments: expected hash 9b5ecb81cf32c34c43cb13310e4b479b6909f3ec got 10271cb9b746fb9b507a9322c16f1279deb69a95
dib.c:1324: Test failed: 4 grayscale: wide pen - empty segments: expected hash 048ce4615962675d66b648631dc556238a86b4df got 9cf16c3165ac241aa6fb50bb0a05c3548fbaeb43
dib.c:1324: Test failed: 1: wide pen - empty segments: expected hash 1dde794388a3ca3ac710acc0aff97f7df70687e5 got e203905ad4c0a609b5ac78e66714b66ffe792b8b
make[1]: *** [dib.ok] Error 14

-- 
Alexandre Julliard
julliard at winehq.org