[3/7] d3dx9: ID3DXConstantTable::SetFloat shouldn't change the value of matrix and vector constants.

Rico Schüller kgbricola at web.de
Mon Aug 20 10:46:31 CDT 2012


On 20.08.2012 17:10, Józef Kucia wrote:
> @@ -665,6 +666,31 @@ static void test_setting_basic_table(IDirect3DDevice9 *device)
>               out[8], out[9], out[10], out[11],
>               out[12], out[13], out[14], out[15]);
>
> +    ID3DXConstantTable_SetFloat(ctable, device, "mvp", f);
> +    ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable mvp: 0x%08x\n", res);

You probably may save res (= ID3DXConstantTable_SetFloat) before 
checking it. Otherwise you are checking the same res value multiple times.

> +    ID3DXConstantTable_SetFloat(ctable, device, "f4", f);
> +    ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable f4: 0x%08x\n", res);


Cheers
Rico



More information about the wine-devel mailing list