[PATCH 3/3] shell32/tests: Add tests for DoEnvironmentSubstA/W
Alexandre Julliard
julliard at winehq.org
Mon Dec 3 07:49:05 CST 2012
Detlef Riekenberg <wine.dev at web.de> writes:
> + /* Not all variables are supported before vista */
> + if (broken(*bufferA == '%'))
> + trace("%d: %s not supported\n", i, bufferA);
> + else
> + {
> + if (i < 3) todo_wine
> + ok(HIWORD(res) && (LOWORD(res) == (lstrlenA(bufferA)+1)) && (*bufferA != '%'),
> + "%d: got %d/%d and %s (len %d)\n",
> + i, HIWORD(res), LOWORD(res), bufferA, lstrlenA(bufferA));
> +
> + if (i < 3) todo_wine
> + ok(HIWORD(res2) && (LOWORD(res2) == (lstrlenW(bufferW)+1)) && (*bufferW != '%'),
> + "%d: got %d/%d and %s (len %d)\n",
> + i, HIWORD(res2), LOWORD(res2), wine_dbgstr_w(bufferW), lstrlenW(bufferW));
> + }
> + }
This doesn't make sense, you are only testing the cases that don't
work. You should pick a few variables that work everywhere, and test
them properly, including the resulting buffer contents.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list