[2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).

Juan Lang juan.lang at gmail.com
Fri Feb 3 10:53:32 CST 2012


Hi Hans,

         hr = IXMLDOMNode_get_text( node, &s );
         IXMLDOMNode_Release( node );
-        if (!strcmpW( s, product_code )) r = ERROR_SUCCESS;
-        SysFreeString(s);
+        if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS;
+        SysFreeString( s );

Is it really safe to free s if IXMLDOMNode_get_text failed?
--Juan



More information about the wine-devel mailing list