[PATCH 1/2] winmm: Avoid using SuspendThread, it can hang Wine.

[Joerg-Cyril.Hoehle at t-systems.com]

Hi,

>this Fixes bug #28388

I think it is not a good idea to defer this patch until after 1.4.0.

Every app using midiStreamOpen eventually calls SuspendThread
which is simply a time bomb on a dual core machine. There are many
more multi-core machines now, so the situation degrades.

Dan Kegel wrote:
>With WINEDEBUG=warn+heap, it happens a lot sooner (first run: first try;
>second run: sixth try).

As noted in the bug report, SuspendThread can hit Wine amid memory
management, breaking havoc. Users won't know who to blame for random
lock-ups and complain like I did that Wine isn't able to generate a backtrace.

Patch 1/2 can be applied stand alone. It gets rid of SuspendThread.

It's been a pleasure to use patch 2/2 and hear apps play midiStream music without trouble.
I wouldn't mind if you defer that for 1.4.1. After all, this is a feature that has been
lacking in Wine for the last 10 years, so people can wait a little more...

Regards,
        Jörg Höhle