ntdll: Fix the file mapping view leak in the case of module loading failure. Take 2.

Alexandre Julliard julliard at winehq.org
Mon Feb 27 09:29:52 CST 2012


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> @@ -1548,6 +1549,11 @@ static NTSTATUS load_native_dll( LPCWSTR load_path, LPCWSTR name, HANDLE file,
>      *pwm = wm;
>      status = STATUS_SUCCESS;
>  done:
> +    if (status)
> +    {
> +        if (wm) free_modref( wm );
> +        else if (module) NtUnmapViewOfSection( NtCurrentProcess(), module );
> +    }

I don't see any evidence that you are addressing the issues that caused
us to not do that in the first place.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list