[PATCH 2/7] wined3d: Move srgb checks away from d3dfmt_get_conv.

[Henri Verbeet]

On 4 January 2012 01:48, Diego Nieto Cid <dnietoc at gmail.com> wrote:
> After adding the conditional to wine-1.3.33, Fallout runs without any
> error.
>
> A patch against HEAD is attached.
>
Looks good to me, please send that to wine-patches, perhaps with a
small comment.

> On Wed, Dec 28, 2011 at 09:17:26PM -0300, Diego Nieto Cid wrote:
>> The HEAD checkout is randomly failing due to
>>
>>     wine: Unhandled page fault on read access to 0x00000000 at address (nil) (thread 0036), starting debugger...
>>     X Error of failed request:  GLXBadDrawable
>>       Major opcode of failed request:  128 (GLX)
>>       Minor opcode of failed request:  5 (X_GLXMakeCurrent)
>>       Serial number of failed request:  621
>>       Current serial number in output stream:  621
>>
>
> HEAD still shows the error above. I'll try to find what happened through
> bisection.
>
> Any idea what to look for? :)
>
The message suggests it's a glXMakeCurrent() / wglMakeCurrent() call
with a bad Drawable / window, perhaps because the window was already
destroyed. It might be something along the lines of
http://bugs.winehq.org/show_bug.cgi?id=29236, although that bug turned
out to be invalid.