[PATCH 1/5] ddraw/tests: Add some clipper tests.

[Alexandre Julliard]

Henri Verbeet <hverbeet at gmail.com> writes:

> On 5 January 2012 18:19, Alexandre Julliard <julliard at winehq.org> wrote:
>> It doesn't work here:
>>
>> ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok
>> ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}.
>> ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}.
>> make: *** [ddraw1.ok] Error 2
>>
> I guess that's because I ran it in a virtual desktop and the
> "GetDCEx(clipper->window, NULL, DCX_WINDOW);" call in
> ddraw_clipper_GetClipList() doesn't return quite the right area
> without it. Can we just remove the todo_wine's? I already have a patch
> to make it use the window's client rect.

If it always succeeds without a virtual desktop, then yes the todos can
be removed.

-- 
Alexandre Julliard
julliard at winehq.org