[PATCH 2/2] winmm/tests: Test some inconsistent WAVEFORMAT descriptions.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Fri Jan 6 02:44:58 CST 2012


Hi,

>Your paranoid android.
>=== WVISTA/W2K8/W7
It's good that I kept the patch to code and tests separated.  The code one should go in,
the tests obviously not (it's not easy to add a broken specific to that case in wave.c).
They tell us that with the introduction of mmdevapi, MS incompatibly changed
the code that checks the validity of WAVE_FORMAT_PCM.
I argue that Wine ought to accept the bad blockalign formats, because w95/w98/w2k/wxp
did render them (check with WINETEST_INTERACTIVE and listen) and some apps used that
(that's why I started investigating this issue at all).
Perhaps the nextp SP will bring compatibility to w7 too?

BTW, regarding
[PATCH 1/2] winealsa: Unify the checks for wBitsPerSample.
despite 1/2, it can be applied on its own, should you object 2/2. That why I split it.

Regards,
 Jörg Höhle


More information about the wine-devel mailing list