comdlg32: Remove the font sample characters string.

Francois Gouget fgouget at free.fr
Wed Jan 18 06:56:02 CST 2012


On Wed, 18 Jan 2012, Frédéric Delanoy wrote:

> On Wed, Jan 18, 2012 at 10:12, Francois Gouget <fgouget at free.fr> wrote:
> > The sample text does not depend on the dialog language but on the scripts supported by the font. As such translating it in the resource file makes no sense.
> > -    CTEXT           "AaBbYyZz",stc5,103,80,109,24,SS_NOPREFIX | NOT WS_VISIBLE
> > +    CTEXT           "",stc5,103,80,109,24,SS_NOPREFIX | NOT WS_VISIBLE
> 
> Actually it's used to show a sample in the font picker (e.g. with
> wordpad do Format > Font).

No it's not. The code overwrites this string when drawing the dialog and 
then based on the entry selected in the 'Script:' combobox (cmb5). See 
CFn_WMPaint():

    if( GetWindowInfo( GetDlgItem( hDlg, stc5), &info ) )
    {
...
        DrawTextW( hdc,                
                sample_lang_text[CHARSET_ORDER[lpcf->lpLogFont->lfCharSet]],
                -1, &info.rcWindow, DT_CENTER|DT_VCENTER|DT_SINGLELINE );
...

So the string which is in the resource file is useless and only causes 
grief.


-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
        A polar bear is a cartesian bear after a coordinate transform.


More information about the wine-devel mailing list