[PATCH 4/5] ddraw/tests: Port the depth blit test to ddraw2
Henri Verbeet
hverbeet at gmail.com
Mon Jan 23 06:48:03 CST 2012
On 22 January 2012 16:32, Stefan Dösinger <stefan at codeweavers.com> wrote:
> + /* FIXME: This is wrong, d3d2 does not have D3DRENDERSTATE_LIGHTING. D3DLVERTEX should
> + * disable lighting. This needs more tests and fixes after Wine 1.4 */
> + hr = IDirect3DDevice2_SetRenderState(device, D3DRENDERSTATE_LIGHTING, FALSE);
It probably makes sense to just skip this call and add a todo_wine for
the failing tests. Also, if all that's needed for this is setting
WINED3D_RS_LIGHTING in IDirect3DDeviceImpl_2_DrawPrimitive(), I think
that should be ok to go in before 1.4.
More information about the wine-devel
mailing list