[PATCH] wined3d: Reduce console flood with an Ogre3D Game

Andrew Eikum aeikum at codeweavers.com
Wed Jan 25 07:39:38 CST 2012


On Wed, Jan 25, 2012 at 02:03:04PM +0100, Henri Verbeet wrote:
> The code looks like it would do what was intended to me. The problem I
> have with it, and I'm pretty sure I've mentioned this before, is that
> reducing debug output shouldn't be a goal on its own. If you're a
> user, and the messages make you feel scared/sad/whatever, just use
> WINEDEBUG=-all, or even WINEDEBUG=-d3d if the other messages do make
> you happy. If you're a developer, just fix the actual problem already.
> 

There's another, similar FIXME in wined3d_swapchain_set_gamma_ramp()
that floods on certain games. These messages are extremely annoying
when trying to check for other, more interesting messages. What about
changing them to WARN so that they don't print to the console by
default? Everyone knows there are workarounds, but is anyone really
gaining anything by having these flood the console?

Andrew



More information about the wine-devel mailing list