[PATCH 1/8] hhctrl.ocx: Implement HH_CLOSE_ALL.

Jacek Caban jacek at codeweavers.com
Thu Jul 5 04:09:39 CDT 2012


Hi Erich,

On 07/04/12 20:32, Erich E. Hoover wrote:
> This series of patches is intended to fix the problems with HTML Help
> associated with Bug #11303 (HtmlHelp causes problems in Elster).  This
> patch implements some of the framework required by the other patches
> through implementing the HH_CLOSE_ALL functionality needed by the
> application to safely shutdown the HTML Help windows on exit.  The
> framework provided in this patch is the ability to register specific
> HTML Help windows (needed later to set and get window properties on
> the fly).

While it's not about this particular patch, I can see that you're
changing hhctrl.ocx to the point where it has an useful API (as opposed
to simple hh.exe-like help viewer). It is really nice to see, thanks. It
would be great to have some tests for this. Please consider adding them
(I'm sure you already have some code for testing, so I imagine it would
be mostly integrating it with Wine test suite).

Thanks,
Jacek




More information about the wine-devel mailing list