joy.cpl: Correct joystick testing thread behavior

Alexandre Julliard julliard at winehq.org
Thu Jul 12 18:00:14 CDT 2012


Lucas Zawacki <lfzawacki at gmail.com> writes:

> @@ -419,14 +421,19 @@ static INT_PTR CALLBACK test_dlgproc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM
>                          SendDlgItemMessageW(hwnd, IDC_TESTSELECTCOMBO, CB_SETCURSEL, 0, 0);
>                          test_handle_joychange(hwnd, data);
>  
> -                        thread = CreateThread(NULL, 0, input_thread, (void*) data, 0, &tid);
> +                        ResumeThread(thread);
>                      }
>                  }
>                  break;
>  
> +                case PSN_KILLACTIVE:
> +                    SuspendThread(thread);
> +                break;

You never want to use SuspendThread, it can't possibly work reliably.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list