[PATCH 1/4] mshtml: Moved IStream::Read calls to separated function

Jacek Caban jacek at codeweavers.com
Fri Jul 27 04:12:17 CDT 2012


On 07/27/12 11:05, Dmitry Timoshkov wrote:
> Jacek Caban <jacek at codeweavers.com> wrote:
>
>> +static HRESULT read_stream(BSCallback *This, IStream *stream, void *buf, DWORD size, DWORD *ret_size)
>> +{
>> +    DWORD read_size = 0;
>> +    HRESULT hres;
>> +
>> +    hres = IStream_Read(stream, buf, size, &read_size);
>> +    This->readed += (*ret_size = read_size);
>> +    return hres;
>> +}
> Using 'ret_size' directly in the IStream_Read call would look more
> natural IMHO, like:
> hres = IStream_Read(stream, buf, size, ret_size);
> This->readed += *ret_size;

Sure, but for patch 3 using separated variable is cleaner, so I
introduced it here already to make the whole series cleaner.

Jacek



More information about the wine-devel mailing list