[PATCH 1/4] server: Move completion from async object to async queue.

Erich E. Hoover ehoover at mymail.mines.edu
Sun Jun 3 14:26:31 CDT 2012


On Fri, Jun 1, 2012 at 8:57 AM, Alexandre Julliard <julliard at winehq.org> wrote:
>
> "Erich E. Hoover" <ehoover at mymail.mines.edu> writes:
>
> > Real Name:
> >     Erich Hoover
> >
> > Description:
> >     It seems that the completion information should be associated with
> > the async queue, rather than the async object, since the completion
> > information for a file handle can be updated after an async IO has
> > been queued.  So, the attached patch moves the completion information
> > from the async object into the async queue so that we can properly
> > handle associating a completion with a file descriptor after an async
> > IO is queued (part 2).
>
> Does it even need to be stored in the queue then?  Why not retrieve it
> from the fd when needed?

Sorry I didn't reply to this sooner, I've been at a wedding at just
got back to the land of the Internet.  I believe that it really does
need to be stored in the queue, otherwise in the case that the async
operation has not completed when the file descriptor is closed then
the cancel completion will not be able to propagate.

Erich



More information about the wine-devel mailing list