winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

Vitaliy Margolen wine-devel at kievinfo.com
Mon Mar 26 20:27:12 CDT 2012


On 03/26/2012 08:15 AM, Alexandre Julliard wrote:
> Vitaliy Margolen<wine-devel at kievinfo.com>  writes:
>
>> On 03/26/2012 06:14 AM, Alexandre Julliard wrote:
>>> Dmitry Timoshkov<dmitry at baikal.ru>   writes:
>>>
>>>> This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass
>>>> on a system without XInput2.
>>>
>>> It will break dinput, we rely on the clip rectangle being reset.
>>>
>> I'd say it again, dinput should not warp mouse under any
>> circumstances. Also, there is such a thing as non-exclusive background
>> mode.
>
> I fail to see how this is relevant here, care to explain?

If Dmitry fixes a real bug that means dinput shouldn't depend on broken 
behavior. And I'm questioning that exact behavior which shouldn't have been 
there in the first place. Dinput's exclusive mode works regardless of what 
ClipCursor is set to.


Vitaliy.





More information about the wine-devel mailing list