[PATCH 3/3] dmsynth: Put port caps that match native ones.

Christian Costa titan.costa at gmail.com
Thu Mar 29 09:30:23 CDT 2012


2012/3/29 Andrew Eikum <aeikum at codeweavers.com>

> Just to be clear, which "native" do you mean? Does this match Windows
> 7's dmusic behavior, or something else? I've been trying to target
> Windows 7's behavior in the new audio design.
>
>
They're recents but I don't remember. I will check this evening. I didn't
know about Windows 7 target but I'm ok with that so I will aligned if
needed.



> Also...
>
> On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote:
> > -     obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB | DMUS_EFFECT_CHORUS
> | DMUS_EFFECT_DELAY;
> > +     obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB; /*
> DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY */
>
> I'd just remove the unused flags. No need for crufty comments.
>
>
>
Ok I will remove them.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20120329/e9d5007c/attachment.html>


More information about the wine-devel mailing list