msxml3: avoid a dangling else (LLVM/Clang)
Michael Stefaniuc
mstefani at redhat.com
Mon May 14 04:35:56 CDT 2012
Hello Austin,
On 05/14/2012 08:01 AM, Austin English wrote:
> diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
> index 6805c75..14fd01b 100644
> --- a/dlls/msxml3/domdoc.c
> +++ b/dlls/msxml3/domdoc.c
> @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML(
>
> /* skip leading spaces if needed */
> if (This->properties->version == MSXML_DEFAULT || This->properties->version == MSXML26)
> + {
> while (*ptr)
> if (isspaceW(*ptr)) ptr++; else break;
I do not mind terse code but that kinda overdoes it. I would put the
"else" on a separate line.
> + }
>
> xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), XML_CHAR_ENCODING_UTF16LE);
> if ( !xmldoc )
bye
michael
More information about the wine-devel
mailing list