[PATCH 1/2] winmm/tests: Add more mmioSeek tests.

[Joerg-Cyril.Hoehle at t-systems.com]

Sagawa San,

it's nice to see somebody contribute to winmm!

+    return;
+}
That return is line noise.

+        hmmio = mmioOpen(NULL, &mmio, MMIO_READ);
+        if (hmmio == NULL) {
+            win_skip("mmioOpen error %u\n", mmio.wErrorRet);
+            return;
+        }
AFAIK mmioOpen has always been present, so there's no reason for a win_skip.
An error should be flagged in all cases, Wine or native.

Furthermore, the early return prevents execution of the other groups of tests.
Hence I suggest:
+        hmmio = mmioOpen(NULL, &mmio, MMIO_READ);
+       ok(hmmio != NULL, "mmioOpen error %u\n", mmio.wErrorRet);
+        if (hmmio) {
              mmioSeek ...
              mmioClose
          }

However, the 2nd and 3rd mmioOpen may fail if the test file could not be created,
so you may want a different treatment there.
Perhaps add a boolean result to create_test_file?


>[PATCH 2/2] winmm: Fix SEEK_END direction of mmio files without buffering.
It's always good in a patch submission to mention what bug it fixes.
Does yours fix bug 19566?  I seem to remember that there was an entry in
bugzilla about MMIO and seeking... Oh yes, you may look at bug 28982,
perhaps your patch fixes that too.

Regards,
 Jörg Höhle