[PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

[Jacek Caban]

On 11/20/12 16:00, Ann and Jason Edmeades wrote:
> On 20 November 2012 12:15, Jacek Caban <jacek at codeweavers.com
> <mailto:jacek at codeweavers.com>> wrote:
>
>     On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote:
>
>         (I'll make this change in try 2, as I need to fix the broken
>         NT4 stuff from patch 1 anyway)
>
>
>     I think it's time to consider skipping all cmd tests on NT4.
>     Adding @or_broken@ for NT4 mostly pollutes those tests.
>
>     Jacek
>
> Please...please... please.... please....
>
> I'm fed up with working around broken and missing functionality in NT4
> for the tests - its taken longer sometimes than writing the code!

Yeah, that's why I hope at some point we will obsolete NT4 just like we
did with Win9x, but that's a subject for separated discussion. Let's
concentrate on skipping individual tests for now.

> Who makes this decision, and if agreed,

It's the usual, someone has to write a patch, send it and see if anyone
objects and is accepted by Alexandre. In this case I don't expect anyone
to object.

> how is the skipping done?

See cmd_available in batch.c. The easiest way to skip NT4 would be
probably to change it to return FALSE on this platform. Note that you
can't explicitly test windows version, but if something like running a
script that you know that fails only on NT4 would do the trick.

Jacek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20121120/cd6a299f/attachment.html>