ntdll/tests: Mark win8 behaviour as broken

Dmitry Timoshkov dmitry at baikal.ru
Mon Nov 26 21:59:38 CST 2012


André Hentschel <nerv at dawncrow.de> wrote:

> diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c
> index c670731..f66d858 100644
> --- a/dlls/ntdll/tests/info.c
> +++ b/dlls/ntdll/tests/info.c
> @@ -1336,7 +1336,8 @@ static void test_mapprotection(void)
>      status = pNtQueryVirtualMemory( GetCurrentProcess(), addr, MemoryBasicInformation, &info, sizeof(info), &retlen );
>      ok( status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %08x\n", status);
>      ok( retlen == sizeof(info), "Expected STATUS_SUCCESS, got %08x\n", status);
> -    ok(info.Protect == PAGE_READWRITE, "addr.Protect is not PAGE_READWRITE, but 0x%x\n", info.Protect);
> +    ok(info.Protect == PAGE_READWRITE || broken(info.Protect == PAGE_NOCACHE | PAGE_READWRITE /* win8 */),
> +       "addr.Protect is not PAGE_READWRITE, but 0x%x\n", info.Protect);

This is not broken. You should either mask PAGE_NOCACHE out before
the comparison, or accept both values.

Same applies to other your patches.

-- 
Dmitry.



More information about the wine-devel mailing list