d3dx9_36 [patch 3/5, try 3]: Implement handy computations for small orders in D3DXSHRotate

Rico Schüller kgbricola at web.de
Wed Oct 10 04:39:49 CDT 2012


On 10.10.2012 09:45, Nozomi Kodama wrote:
> +        CONST FLOAT coeff[]={
>
> +        out[7] -= (matrix->u.m[1][0] * matrix->u.m[0][2] + matrix->u.m[1][2] * matrix->u.m[0][0]) * in[4];
> +
> +        out[7] += (matrix->u.m[1][0] * matrix->u.m[2][2] + matrix->u.m[1][2] * matrix->u.m[2][0]) * in[5];
Empty line too much?

> +        for ( l = 0; l < 1; l++)
>
> +            if (l == 0)
> +                out_temp = out;
> +            else
> +                out_temp = in;
The test change is completely new in the try... What do you like to 
achieve with this? l is always 0, isn't it? Beside this, there are some 
white space issues.



More information about the wine-devel mailing list