[PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 2)
Alexandre Julliard
julliard at winehq.org
Mon Oct 22 13:35:58 CDT 2012
Christian Costa <titan.costa at gmail.com> writes:
> @@ -236,20 +236,32 @@ BOOL WINAPI GetClientRect( HWND hwnd, LPRECT rect )
>
>
> /*******************************************************************
> - * ClientToScreen (USER32.@)
> + * ClientToScreen (USER32.@)
> */
> BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
> {
> + if (!IsWindow( hwnd ))
> + {
> + SetLastError( ERROR_INVALID_WINDOW_HANDLE );
> + return FALSE;
> + }
> +
You should never use IsWindow(). Handles should be checked at the point
where they are used.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list