crypt32: Avoid double free in CRYPT_LoadSIP on error path (coverity))

Nikolay Sivov bunglehead at gmail.com
Mon Oct 29 04:37:56 CDT 2012


On 10/29/2012 11:33, Frédéric Delanoy wrote:
> FreeLibrary(temp) can be called twice on error.
>
> CID 714004
> ---

>   
>   error:
>       FreeLibrary(lib);
> -    FreeLibrary(temp);
> +    if (temp != NULL) FreeLibrary(temp);
>       SetLastError(TRUST_E_SUBJECT_FORM_UNKNOWN);
>       return FALSE;
>   }
This is useless, FreeLibrary() checks for NULL.



More information about the wine-devel mailing list