Question from new developer

Dan Kegel dank at kegel.com
Sun Sep 23 10:19:18 CDT 2012


Chris wrote:
> 1. I discovered later that I don't think this is the root of my
> original bug - and in fact doesn't seem to affect behavior of my
> program.  Is it still worth submitting?

Generally, fixes are more likely to get committed when they
don't break anything (did you run all the conformance tests?),
their tests cases pass on all versions of windows (did you send
your patch to testbot?), improve the behavior of a real program
(I don't think you have demonstrated this yet), and
are written from a position of relatively deep understanding.

So you might want to find a more solid fix for your first submission.

Welcome, and good luck!
- Dan



More information about the wine-devel mailing list