[PATCH 1/1] d3d8: Don't assert on invalid IDirect3DBaseTexture8 interfaces.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-04-15 10:53, schrieb Rico Schüller:
> I'm not sure what GetTexture does, a test might show it (I'll have
> a look). The problem might be, that we use some members, which
> native probably doesn't do in SetTexture. You couldn't call
> GetTexture in wine with uninitialized memory as we do currently,
> that's why I think using NULL is the way to go.
Given the circumstances, the patch is probably the correct way to go, yes.

Does the game just do the broken SetTexture call once, or does it
repeatedly try to use the released texture?

What happens when you pass an invalid pointer (e.g. (void
*)0xdeadbeef)? What happens when you pass a valid pointer that points
to memory filled with zeros or garbage? If SetTexture does not crash,
what is the return value?

> Please have a look at http://bugs.winehq.org/show_bug.cgi?id=33055
> . Well I think there might be some memory corruption somewhere, but
> it doesn't have anything to do with the this bug as we use already
> freed memory in our implementation.
I don't see anything in the log that would keep the texture around.
There may be some capability flag issues that trigger a broken
codepath in the game, but such an issue is really hard to find.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRa+l9AAoJEN0/YqbEcdMw9qsQAJFvdFH3jGhrVsyII++ART9J
etfmFEfsFcw99m1mkPfpUsPqtlk0tiwWJ5OTI6pcoa5zAqh03e9sr83xQYvxyX/J
B155EW5CepOMbTKHbedPyS2UXYcdRCFxN0w6wVcWRMap7WTLNPWLC4A7XGFNhkSZ
ZIDM7IlDjOntHij74tdxEzx+xs/aZsgaTcfWaxX3IzrHsxOb2gywKI3NcrTg+TNT
yQvTq9ac2jeZ4U7nHnASAfg9TYZtIdNygK1DhuHWTx9QEo+Xb+Ik09VR4zYWmCEt
EFqxIcNnSqCDqVO9lDigEpUSLBqfpxTBdb6SPnQ6vJhwjO/XTYl3fKWzby3IVgEH
wo8p+T7f3n+rnpNocQ7BQlVjwIqyRwsPj6B65xaB9Sxv+zd1hTiPD7diwLh4bveX
VEpSXRkfESAOUgnj8HWiRczSb/9GN2m2YCdgiHIyXMDd3TcvNagncK2o5ROC9s3i
cN2rdyP7nFYRZzwyn6ttN+gAeFjcK1Ryk37nCF77HkKiFCqE6cqGTYnQxDPH8D2m
xaKj36vjswg1Tk6PoZ1CN/isW99psbRHaNcdimW0ExcoboiePD8qMhdFLHZ2a123
Bdbti4zUkUIhGt3VnE7MQyMZ2ivWLSXrbQplFQcViz6gmJB+hm+LJl+ONBRNky1j
ADcAEILlJ8JVLXR9EDCV
=QLR7
-----END PGP SIGNATURE-----