[user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()
Alexandre Julliard
julliard at winehq.org
Fri Apr 19 12:53:17 CDT 2013
Dan Kegel <dank at kegel.com> writes:
> On Fri, Apr 19, 2013 at 10:38 AM, Dan Kegel <dank at kegel.com> wrote:
>> Hooking is a fragile business. Somebody somewhere is probably
>> making assumptions about how hooking works (like, how many stack
>> frames are pushed), and inlining call_hook_proc probably violates one
>> of those assumptions.
>
> That said, this is all a big guess. It would be nice to have a
> test that demonstrated the problem. It's up to Alexandre to
> decide whether making a couple apps happier is evidence
> enough that disabling inlining of this one function is a good idea.
It's not. Please take the time to understand the problem and fix it
properly.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list