[PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.
Ken Thomases
ken at codeweavers.com
Wed Aug 21 23:34:36 CDT 2013
On Aug 21, 2013, at 9:42 PM, Charles Davis wrote:
> @@ -90,6 +93,9 @@ static CFDataRef export_hdrop_to_filenames(HANDLE data);
> static CFDataRef export_oemtext_to_utf8(HANDLE data);
> static CFDataRef export_text_to_utf8(HANDLE data);
> static CFDataRef export_unicodetext_to_utf8(HANDLE data);
> +static CFDataRef export_oemtext_to_utf16(HANDLE data);
> +static CFDataRef export_text_to_utf16(HANDLE data);
> +static CFDataRef export_unicodetext_to_utf16(HANDLE data);
Please keep the export_* functions sorted (although I'm fine with utf8 coming before utf16). This applies to the function definitions, too. (Yes, this is an exceedingly minor issue. Sorry.)
> +static HANDLE import_utf16_to_unicodetext(CFDataRef data)
> +{
> + const WCHAR *src;
> + unsigned long data_len;
> + unsigned long new_lines = 0;
> + LPWSTR dst;
> + unsigned long i, j;
> + HANDLE unicode_handle = NULL;
This is an unnecessary initialization / dead store, which is frowned upon.
Thanks!
-Ken
More information about the wine-devel
mailing list