[PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.

Charles Davis cdavis5x at gmail.com
Wed Aug 21 23:49:36 CDT 2013


On Aug 21, 2013, at 10:34 PM, Ken Thomases wrote:

> On Aug 21, 2013, at 9:42 PM, Charles Davis wrote:
>> +static HANDLE import_utf16_to_unicodetext(CFDataRef data)
>> +{
>> +    const WCHAR *src;
>> +    unsigned long data_len;
>> +    unsigned long new_lines = 0;
>> +    LPWSTR dst;
>> +    unsigned long i, j;
>> +    HANDLE unicode_handle = NULL;
> 
> This is an unnecessary initialization / dead store, which is frowned upon.
I was only blindly copying the code that you wrote ;).

Chip




More information about the wine-devel mailing list