[PATCH 5/5] wined3d: Implement basic volume location management

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-08-22 10:25, schrieb Henri Verbeet:
> Yeah, I'm not particularly happy about it either. The issue is
> that scratch resources allow some extra formats over sysmem
> resources, but can't be used for resource uploads. The idea is to
> eventually push the concept of pools out into d3d8 and d3d9, and
> just have access flags in wined3d, but we'd still need to be able
> to distinguish scratch resources from sysmem resources somehow. At
> the moment I'm thinking the better option would be to pass that
> through the creation flags instead, i.e. have a flag like
> WINED3D_SURFACE_SCRATCH, although ideally at the resource level.
I think it's best to check the pool in operations that accept a
resource as parameter. We already do that in most places.
Update_texture on volumes doesn't, but a later patch in my series
fixes that.

And yeah, long-term we want pool and usage to go away from wined3d and
stay in d3d8/9.

Wrt wined3d_volume_validate_location and
wined3d_volume_invalidate_location: Should
validate_location(LOCATION_X) just add LOCATION_X to the valid
locations, or invalidate all others? (i.e., should it do a logical or
or an assignment)? I currently implement it as logical or, so in some
cases the caller is responsible for calling invalidate_location on the
other locations.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSFd+sAAoJEN0/YqbEcdMwkJQP/30+RdD61lcUYmTOm8S2vPqR
nvcX6DTdcuoKV0I7W/9dg+lOx4tKgll37pSCyp7B0nsXKcHS3keXlvc9gTnNSgu5
LDJRsIc4DYbHU9BR5nbsG7gx6yjWg6LcS63DxIaIZLk0MbhKJaPKs2enXOVPJyVd
e8UW2bf855MACPFIeBRI8o5vNH5L8R6jFsXb0P5qHIu1c/L4Du0VAYa3EaFtGWYj
q2pAsAfKnjxedERIYIQ33FGHPucXhJ8254+silvgKwkfGLZTF40sKxFLnjxz/XTW
eM7kL7LJOfcqcgmpb+wgjfQMNXeNiu3YERYoIwE5+jFB+uPZy0u+WCxpDa8xI8HF
K4hpMIW0F01NbG6p/rSJWS75YMjlCJT4w/La0UTbSQ14ML8s+1OtrZBEvksTikFl
KmiXhzTNNwDLUL2E9EEboQHsxJZ9AXjOxEm3xlfB2afay5+gPg6Kox2tiG/wyN2M
ReGmvpOC6Ddrdf7Bvror1AOVni1h4GTsF3yh/507ea1gU4oaKBz33nz4DPVvvVzD
DvHlMQUGenxANYzskqAJT9KygpNuK2bgsBawGxqYKo7DyEF8wO1suu3pzb0vPwiT
SRr/VWtD7e2HksrhTjlE5ToLr9nFFO5Xk/dhOzOCetAayBJ5jbil//gtD1fparw6
5ZYIdkWufcxTALuA6ZE8
=Wym2
-----END PGP SIGNATURE-----