[PATCH 5/5] wined3d: Implement basic volume location management

Henri Verbeet hverbeet at gmail.com
Thu Aug 22 05:58:41 CDT 2013


On 22 August 2013 11:53, Stefan Dösinger <stefan at codeweavers.com> wrote:
> I think it's best to check the pool in operations that accept a
> resource as parameter. We already do that in most places.
Yes, but if "pool" goes away we need some other way to check for
scratch resources. It's just that in retrospect the access flags
probably aren't the right place.

> Wrt wined3d_volume_validate_location and
> wined3d_volume_invalidate_location: Should
> validate_location(LOCATION_X) just add LOCATION_X to the valid
> locations, or invalidate all others? (i.e., should it do a logical or
> or an assignment)? I currently implement it as logical or, so in some
> cases the caller is responsible for calling invalidate_location on the
> other locations.
>
Yes, logical or.



More information about the wine-devel mailing list