my patch was wrong at dlls/kernel32/computernames.c

Marcus Meissner meissner at suse.de
Thu Aug 29 09:35:39 CDT 2013


On Thu, Aug 29, 2013 at 11:31:06PM +0900, matyapiro31 wrote:
> From
> if ( isalnumW ( wc ) ) return wc;
> for ( i = 0; i < 17; i++ )
> To
> if ( isalnumW ( wc ) ) return wc;
> for ( i = 0; i < 16; i++ )
> and the original version was wrong,too.
> It counts the NULL of the end.

Thats why you should use sizeof() or strlen() ... and not hardcoded magic values.

CIao, Marcus



More information about the wine-devel mailing list