[PATCH 3/5] ddraw: Change surface pitch before width.

[Stefan Dösinger]

Am 13.12.2013 um 14:18 schrieb Henri Verbeet:
> On its own this patch is perhaps innocent enough, but it looks like
> this is supposed to make 4/5 safe, in which case that patch ends up
> depending on a somewhat obscure implementation detail. I think it may
> be better to merge wined3d_surface_set_mem() into
> wined3d_surface_update_desc(), at least as far as the public interface
> is concerned.
The result would be pretty close to ddraw_suface::SetSufaceDesc, and I'm not particularly happy with that design. We'd have to provide similar constraints about which properties must be set together and which properties can remain untouched.

But if you think that's better than relying on the call order of update_desc and set_mem I'll see if I can make it work in a way I like.