kernel32/tests: add test for RemoveDirectory

[Zhenbo Li]

2013/12/25 Dmitry Timoshkov <dmitry at baikal.ru>:
> Zhenbo Li <litimetal at gmail.com> wrote:
>
>> +    /* remove a nonexist directory */
>> +    rc = RemoveDirectoryA(directory);
>> +    todo_wine
>> +    ok(!rc && GetLastError() == ERROR_FILE_NOT_FOUND,
>> +        "Expected ERROR_FILE_NOT_FOUND, got ret=%d, gle=%d\n", rc, GetLastError() );
>
> This kind of test for several values simultaneously is really very awkward
> as a starting point for any person who is going to work on this, or just is
> looking for a simple bug to fix and greps for todo_wine in the tests. First
> of all it's not clear where the failure is: is it the API failing to return
> correct return value, or is it just last error which is set differently?
> I admit that the error message mentions both values, but it's often more
> useful to spot areas with todo_wine statements and clearly see the reason
> of a failure without actually running the test.
>
> --
> Dmitry.

You are right, I'll send another patch.

-- 
Have a nice day!
Zhenbo Li