[4/4] windowscodecs: Implement IWICComponentFactory::CreateDecoderFromFileHandle.
Hans Leidekker
hans at codeweavers.com
Wed Feb 6 12:02:03 CST 2013
On Wed, 2013-02-06 at 10:25 -0600, Vincent Povirk wrote:
> > + hr = map_file(file, &map, &mem, &size);
> > + if (FAILED(hr)) return hr;
> > +
> ...
> > +
> > + hr = IWICStreamImpl_InitializeFromMemory(stream, mem, size.u.LowPart);
> > + if (FAILED(hr)) goto error;
>
> This makes me sad.
>
> Is this really simpler than implementing Write and Seek for a file handle?
I'd say it's a comparable amount of code. I don't have a strong preference for
either option.
More information about the wine-devel
mailing list