Truncate MIDI SysEx messages after termination byte

Christian Costa titan.costa at gmail.com
Mon Jan 14 13:41:49 CST 2013


Le 14/01/2013 19:04, Christian Costa a écrit :
> 2013/1/14 Christian Costa <titan.costa at gmail.com>:
>> 2013/1/14  <Joerg-Cyril.Hoehle at t-systems.com>:
>>> Hi,
>>>
>>> Christian Costa wrote:
>>>> I took a look at the
>>>> alsa code and this code simply does not do what it is supposed to.
>>> I also looked at it today and noted those bogus lines you quote. Needs
>>> a patch (+ fix memory leak).
>> I will take a look at it and send a patch unless someone plan to do it.
>> I will not  be able to test with my 2 HW midi devices right now so I need
>> someone to test it. That would be good to enter a bug report for that.
>> Johannes, can you do that?
>>
>>> However, Johannes' change is presumably different, as he wants to
>>> scan the buffer contents for a F7 terminator and ignore subsequent
>>> bytes.  If I were to decide, I'd like to see more supporting evidence.
>> In the case the first by is F0 and the last one is F7, the code passes
> I meant "last one if not F7".
>
Here are a patch to fix modLongData.
I tested it with the unit test attached.
Please give it a try.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.patch
Type: text/x-patch
Size: 1109 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130114/2a528576/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.c
Type: text/x-csrc
Size: 1358 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130114/2a528576/attachment.c>


More information about the wine-devel mailing list