Truncate MIDI SysEx messages after termination byte

Christian Costa titan.costa at gmail.com
Fri Jan 18 11:18:51 CST 2013


2013/1/18  <Joerg-Cyril.Hoehle at t-systems.com>:
> Hi,
>
> Although I wouldn't mind inclusion of Christian's F0/F7 patch in upcoming Wine
> (barring decent formatting),

Well, it's not a formatting problem. It was intentional. The Wine
preferred style is 4 spaces indentation and no tab
but I didn't know that when I wrote the alsa midi driver. I took
wineoss one as a base without doing a cleanup.
I asked to Alexandre one day how to fix this kind of thing and he told
me to fix only the code I change as long as this fits
nicely with the code and it was for d3dxof which is 2 spaces
indentation. In this case it's a mix of tabs and space.
Replacing with space only looks the same and anyway last part of the
function is 4 spaces too. I admit I cleaned the whole function
whereas less than half of the code was changed. If something has
changed let me know.

Christian



More information about the wine-devel mailing list