[PATCH] windowscodecs: Add support for DIB format.

Dmitry Timoshkov dmitry at baikal.ru
Mon Jan 21 23:32:34 CST 2013


Vincent Povirk <madewokherd at gmail.com> wrote:

> Yes, it is possible that I wrote more code than was necessary to
> support TGA because I knew WIC better and because I thought it'd be
> cool (in theory the decoder can now be used outside the context of
> d3dx9, for instance on windows with the builtin image viewer - not all
> that useful but still pretty cool imo).

Adding Wine specific extensions should be slightly more justified IMHO.

> For DIB it is less code because all of the logic involved is already
> used to support BMP or ICO, and all of the real work for it was done
> at the same time as adding ICO support.

I'd argue that it's even less code to load a DIB since gdi32 has full
built-in support for it. Taking into account all the overhead that COM
adds (although in d3dx9 case it's already there) writing a new WIC codec
is not always justified.

-- 
Dmitry.



More information about the wine-devel mailing list