[PATCH] mscms: Use lcms2, when available [try 2]

Hans Leidekker hans at codeweavers.com
Mon Jun 3 03:30:37 CDT 2013


On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote:
> try2:
> import the unchanged icc34.h from the lcms (v1) dev. package.
> (Do we need to add a Wine LGPL licence header for icc34.h?)
> 
> The plan is to remove this include, when changing Wine
> to use the new getter/setter functions of lcms2
> (After the release of Wine-1.6)

My plan was to switch to lcms2 soon *after* the release of Wine 1.6. I studied
the API some more and my conclusion is that while it doesn't have all we need
(specifically cmsReadRawTag and cmsWriteRawTag don't do what we want), we can
avoid importing the icc34.h header.

I'm not in favor of adding temporary workarounds. If distributions want to
drop support for lcms1 in 1.6 I'd suggest that they backport the patches.





More information about the wine-devel mailing list