[PATCH 2/5] wined3d: Handle fog_start==fog_end with table fog(try 2)

Stefan Dösinger stefan at codeweavers.com
Tue Jun 18 07:09:48 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-06-18 12:53, schrieb Henri Verbeet:
> (And that one is only supported by Mesa anyway, so there should be 
> no reason to not just fix the driver instead.)
Well, in theory. In practice I'd need the register documentation. I
had a very quick look at the mesa code, and it isn't as simple as
removing something like "if (start == end) annoy_wine();". There's a
register flag R200_FOG_TABLE that may or may not provide what d3d wants.

Supposedly the register documentation of r200 is available, but Google
doesn't find it.

>> I can deal with ARB in another way, by implementing the fog 
>> equation myself instead of using #option ARB_fog_linear. That 
>> would throw pre-sm2 hardware under the bus though.
>> 
> Yeah, we probably don't want that. I think the value of the ARB 
> program backend is limited, but it's main target should be pre-SM2
>  hardware that can't do GLSL. (And potentially still has dedicated 
> fog hardware.)
Since I'm still maintaining the ARB code, I prefer something like the
attached patch over failing tests any time.
(It's not quite done yet. The patch needs splitting, the quirk test
should test an ARB shader and I'll probably limit the custom code to
start == end cases.)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRwE4GAAoJEN0/YqbEcdMwweMP/3IZhKiTeaVnhmVg1nfHBpjG
hegDyIfFKVa1Xy2yxV3fYiKhYxuXHzHRl7pQ8qJlNLttoq2i/MMYZuQcZ9Ww3xWd
sHs/UD+RTQgGasNxYYx1Ody/yjHt+fx+98rXSR2b31/oyjmzijnLZqmSr/8JSB3/
JYSNkKSW91GG/IAlcp2C4QZZo+upg4t29+WPHn4aeQeYX/oxlY6rQFVrlWwb7UBN
FQL9WV29ah8Wb3jeGp5UZM0Z8C83cu5efRH5kyGsdM/8YcPzqHAoHuFv3vmnpJxi
dze41y0RqgZMsocFog/VlegZqCheH1alDEmRuEkl1/1jIBGgHnJsw2FggjJ+veEg
zkGmt9GXPjn2u0+gcj48a2FDpLZw5UAdwaI5jKyoDVsTY/cSk8RdoxlqcQVcu6BI
xWx1XaAyjPwg81mvVyugyR0B+GSIsfXXhYl1kCExwLXuFam4Vn0RkPbwcdj1WHem
g3ufGT9FHGeftCmnXMLR9ETSiHdgnB6/oabwe7fc5zLBAGfgi8fTYB4DZvXpqWas
ZWAcunRRpDuIA4w7xqjYFqWNF8J6WIouki1sUrCvd/lNtBXM9ieRHgG28qY8h9JO
9xeC7UCh950juECgocTYz3W1qqsrEL9fmmbVp0HdltiBtqmTBfFSxuDtfWIN7ViZ
9HsSdt/Bw0tiXy3uRvlN
=8SHq
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wined3d-Handle-fog_start-fog_end-with-table-fog-try-.patch
Type: text/x-patch
Size: 15559 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130618/bc0905b2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wined3d-Handle-fog_start-fog_end-with-table-fog-try-.patch.sig
Type: application/pgp-signature
Size: 543 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130618/bc0905b2/attachment-0001.pgp>


More information about the wine-devel mailing list