[PATCH 3/4] ddraw: Device2 and Device3 do not have a lighting render state

Stefan Dösinger stefandoesinger at gmail.com
Thu Jun 20 06:18:27 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-06-20 13:02, schrieb Henri Verbeet:
> On 20 June 2013 12:17, Stefan Dösinger <stefan at codeweavers.com>
> wrote:
>> /* Light state */ DWORD material; +    DWORD dummy_rs_lighting;
>> 
> Considering the render state doesn't exist in early ddraw versions,
> do we really care that its value is preserved? It seems unlikely
> that anything except our tests would depend on it.
I don't know any application that depends on this. It just seemed like
an interesting thing to test to see how far the interaction between
the different APIs goes.

Just to make sure I understand you correctly: You're saying that the
test should still call SetRenderState(LIGHTING), check the initial
value, and GetRenderState(LIGHTING) should return a hardcoded 0xffffffff?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRwuUDAAoJEN0/YqbEcdMwDCAQAJAGmdgE2CP6ZwMudC1x77eh
SORFI6G/U8vO+6zv39KWAStA9S6KB9MOJuHGo8ytVxscn5UxXo7QR4+WqtKc4G6M
75Qry5gsHRvHEa9YeJIcJttjZq49+htZ0rWmt2HxI4+XC4aeIpsQWBNDoJLBE94P
+M915aZPrBB7rurhGqgWBQ/lDt9o0ov2obH2NUJj8Ze7KKPYIT150rRVxbS1qqbp
D0DpIKT+4rgUukx77zN6jQ7+gegUGTQodbhD1VKaD0HicCBEPJ4l8/dB3Q8bvfa+
Xe/E69/5YmslMO74rYD702grNOiGhHAcRQbetqxllcGivIOrO1CWCP88465uhfED
pLD+7aIoVqcroj5ifgQkGtrZ4tcSN6GoJcvy5x+7d0OtiJmf8xHeHjw8SF7fqCQk
Uy4/t5IRrAcOzR9v81lp+38hVUUpminc3cW9YK8nEQDCyHTxi9MWalOoU1xR0Zlm
qtkpYPxjZoNl4aju2xC2t+AanjsX/9+VRsmiY5hj4j5QE2o0Wsp9c6Y75XsdCuGR
SHMJkeq1DfthNhMJTpF4eMG4HdW00nxtrAT14WRUq+I6vlgRXjgUYrw4GgJRFFYW
diqeqj+KJtDErTP/X3jlnLZhw6Dy2sLq0J/inoXjom6oZPvgCXfPDEq0nupQzE8y
ef9JQ1JCpo5NJ4E8rZZU
=oVUh
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list