gdiplus/tests: Skip the tests if unable to load the TIFF image.

[Francois Gouget]

On Mon, 4 Mar 2013, Dmitry Timoshkov wrote:

> Francois Gouget <fgouget at codeweavers.com> wrote:
> 
> > On Windows XP most versions of gdiplus (i.e. older than 5.2) do not support TIFF.
> 
> I'd suggest to upgrade the VM instead.

I intend to upgrade the VM. However I don't consider upgrading it and 
fixing the test as being mutually exclusive.


> Ideally each VM should represent a Windows version with newest service 
> pack installed it's supposed to run the tests on, otherwise that VM is 
> useless. IMHO there is no point in changing the tests to workaround a 
> broken VM state.

I disagree with your 'ideal' and I don't regard a Windows system that is 
not running the very latest updates as broken. Also note that installing 
Windows XP's latest service pack is not sufficient to fix this (you need 
unidentified post-SP3 updates).

The goal of the Wine tests is to document the Windows behavior that 
Windows applications expect. For a long time people held off on 
installing Windows XP's SP2 and then SP3 for various reasons so that 
most applications could not depend on them being installed. Of course a 
lot has happened since so our standards on the applications expectations 
must evolve. It also depends about how much we care about old Windows 
applications.

As far as the WineTestBot is concerned I expect the community, rather 
than me, to set the policy on this. So far the consensus seems to be 
that for XP and older we don't care about running the tests on versions 
that don't have the latest service pack. So that's what I'm working on. 
For Windows 7 however I believe the goal is to run the tests in both 
pre-SP1 and post-SP1 environments. (I'm not sure about the consensus for 
those in between).


That said I also consider that the tests should not fail for no good 
reason. That only leads to situations where winetest only succeeds on 
Alexandre's machine. Lack of TIFF support seems easy to deal with and 
since it's normal for slightly out of date systems I think a win_skip() 
is appropriate.


-- 
Francois Gouget <fgouget at codeweavers.com>