[1/2] include: Implement part of nserror.h

Nikolay Sivov bunglehead at gmail.com
Mon Mar 11 07:55:24 CDT 2013


On 3/11/2013 13:41, Jeff Latimer wrote:
> On 11/03/13 17:43, Nikolay Sivov wrote:
>> On 3/11/2013 10:27, Jeff Latimer wrote:
>>> ---
>>>   include/nserror.h | 226
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 226 insertions(+)
>>>   create mode 100644 include/nserror.h
>>> +#ifndef _NSERROR_H
>>> +#define _NSERROR_H
>> This doesn't look right.
> This is the same as the SDK, atleast to my eye.  Is there something in 
> particular that appears wrong?
See how it's done in existing headers.
>>
>>> +#define NS_S_CALLPENDING _HRESULT_TYPEDEF_(0x000D0000L)
>> This is usually done with a suffix.
> I have done this as the SDK does it.  I thought that was the way we 
> liked it.
Sorry, I meant to say 'without a suffix'. See how _HRESULT_TYPEDEF_() is 
used in winerror.h for example.
>>
>>> +
>>> +#endif
>> Please add a comment here.
> Ok. 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130311/17050486/attachment.html>


More information about the wine-devel mailing list