mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 3)

Alexandre Julliard julliard at winehq.org
Fri Mar 15 07:47:52 CDT 2013


<Joerg-Cyril.Hoehle at t-systems.com> writes:

> The only comments about v2 were Michael Stefaniuc
> suggesting a refactoring and me explaining why
> in this particular case, that would not be a good idea.
> http://www.winehq.org/pipermail/wine-devel/2013-March/099068.html

It's still a good idea, even if the function is ultimately used only in
one place.

> For v3, I've renamed MulDiv64 to UMulDiv64. Unlike QueryPerformanceCounter,
> mmdevapi GetPosition operates on unsigned values.

That's a bad name. Don't make internal functions look like Win32 APIs.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list